Emit declarations for function overloads #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have an overloaded function the declaration doesn't emit type on the function body, so you have to duplicate it.
Practically speaking, usePagination does not allow
null
in TypeScript with the current release because that definition is not emitted.While I was modifying these, I made them also accept
undefined
which you often get from Relay generated types. It is handled the same as null.Test Plan
npm run compile
lib/usePagination.d.ts
has ausePagination
definition that accepts null/undefined for the fragmentRef