Skip to content

Conversation

saudzahirr
Copy link
Contributor

@saudzahirr saudzahirr commented Oct 7, 2025

Add Sparse Grid Designs using Smolyak’s construction, including doe_sparse_grid, and sparse_grid_dimension with docs and tests.

@saudzahirr
Copy link
Contributor Author

Implementation of Sparse Grid Design #16

@saudzahirr
Copy link
Contributor Author

saudzahirr commented Oct 7, 2025

@relf @EwoutH @quaquel Please review these changes!

@EwoutH
Copy link

EwoutH commented Oct 8, 2025

Thanks for this work!

Generally, it looks good and complete.

The pyDOE3 module provides sparse grid construction using Smolyak's construction [Smolyak1963] for generating experimental designs with hierarchical grid structures that maintain good space-filling properties while requiring significantly fewer points than traditional full grid approaches in high-dimensional spaces.

This implementation is based on the MATLAB Sparse Grid Interpolation Toolbox by Andreas Klimke [Klimke2005] and provides exact compatibility with MATLAB spinterp's spdim function.

It's nice that it's based on a an existing implementation.

I'm not sure if the convenience features doe_sparse_cc and doe_sparse_chebyshev are needed. @relf can maybe give insights on the best practices for API design for this repo.

@quaquel, what do you think of this implementation? Are these the right (or at least useful) Sparse Grids? Is this useful for non-full-factorial experimental designs in your opinion?

Copy link
Owner

@relf relf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @saudzahirr! Looks like you are DOE-ing very well! 😄

@saudzahirr saudzahirr force-pushed the feature/add-sparse-grid-designs branch from f9264d9 to 1df348a Compare October 9, 2025 16:06
@saudzahirr saudzahirr requested a review from relf October 9, 2025 16:07
@saudzahirr
Copy link
Contributor Author

Thanks @saudzahirr! Looks like you are DOE-ing very well! 😄

Another day, another DOE! 😎

@saudzahirr saudzahirr force-pushed the feature/add-sparse-grid-designs branch from 1df348a to a3033cf Compare October 9, 2025 18:55
@saudzahirr
Copy link
Contributor Author

@relf, @laraibg786 and I are planning to modernize the docs by migrating from Sphinx to MkDocs (Material theme), similar to Pydantic’s docs. Would you be open to a PR for this?

@saudzahirr
Copy link
Contributor Author

@EwoutH please review the changes.

@relf
Copy link
Owner

relf commented Oct 10, 2025

@relf, @laraibg786 and I are planning to modernize the docs by migrating from Sphinx to MkDocs (Material theme), similar to Pydantic’s docs. Would you be open to a PR for this?

Sure, I also prefer markdown

@saudzahirr
Copy link
Contributor Author

@relf I propose that we proceed with the release once @EwoutH approves the PR. What are your thoughts?

@saudzahirr
Copy link
Contributor Author

@EwoutH waiting for your approval!

@EwoutH
Copy link

EwoutH commented Oct 14, 2025

I will try to take a look later today.

@saudzahirr
Copy link
Contributor Author

Hi @EwoutH, just following up on this. All checks have passed and @relf has approved. Would you be able to take a final look so we can proceed with the merge and the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants