Skip to content

Remove empty assets object from wrangler config #13302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Remove empty assets object from wrangler config #13302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fddd60
Remove empty `assets` object from `wrangler.toml`
smorimoto Mar 29, 2025
0a79903
Bump `cloudflare/workers-sdk` packages
smorimoto Mar 29, 2025
ef9da26
Add @smorimoto to contributors list
smorimoto Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@
- SkayuX
- skratchdot
- smithki
- smorimoto
- soartec-lab
- sorokya
- sorrycc
Expand Down
4 changes: 2 additions & 2 deletions integration/helpers/cloudflare-dev-proxy-template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@
"react-router": "workspace:*"
},
"devDependencies": {
"@cloudflare/workers-types": "^4.20250317.0",
"@cloudflare/workers-types": "^4.20250404.0",
"@react-router/dev": "workspace:*",
"@react-router/fs-routes": "workspace:*",
"@react-router/remix-routes-option-adapter": "workspace:*",
"@types/react": "^18.2.20",
"@types/react-dom": "^18.2.7",
"typescript": "^5.1.6",
"vite": "^6.1.0",
"wrangler": "^4.2.0"
"wrangler": "^4.7.1"
},
"engines": {
"node": ">=20.0.0"
Expand Down
4 changes: 2 additions & 2 deletions integration/helpers/vite-plugin-cloudflare-template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"serialize-javascript": "^6.0.1"
},
"devDependencies": {
"@cloudflare/vite-plugin": "^0.1.13",
"@cloudflare/vite-plugin": "^0.1.21",
"@react-router/dev": "workspace:*",
"@react-router/fs-routes": "workspace:*",
"@types/node": "^20.0.0",
Expand All @@ -28,7 +28,7 @@
"typescript": "^5.1.6",
"vite": "^6.1.0",
"vite-tsconfig-paths": "^4.2.1",
"wrangler": "^4.2.0"
"wrangler": "^4.7.1"
},
"engines": {
"node": ">=20.0.0"
Expand Down
2 changes: 0 additions & 2 deletions integration/helpers/vite-plugin-cloudflare-template/wrangler.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,5 @@ name = "react-router-app"
compatibility_date = "2025-03-17"
main = "./workers/app.ts"

assets = {}

[vars]
VALUE_FROM_CLOUDFLARE = "Hello from Cloudflare"
2 changes: 1 addition & 1 deletion packages/react-router-cloudflare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
}
},
"devDependencies": {
"@cloudflare/workers-types": "^4.20250317.0",
"@cloudflare/workers-types": "^4.20250404.0",
"react-router": "workspace:*",
"tsup": "^8.3.0",
"typescript": "^5.1.6",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-router-dev/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
"typescript": "^5.1.6",
"vite": "^6.1.0",
"wireit": "0.14.9",
"wrangler": "^4.2.0"
"wrangler": "^4.7.1"
},
"peerDependencies": {
"@react-router/serve": "workspace:^",
Expand Down
4 changes: 2 additions & 2 deletions playground/vite-plugin-cloudflare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"serialize-javascript": "^6.0.1"
},
"devDependencies": {
"@cloudflare/vite-plugin": "^0.1.13",
"@cloudflare/vite-plugin": "^0.1.21",
"@react-router/dev": "workspace:*",
"@react-router/fs-routes": "workspace:*",
"@types/node": "^20.0.0",
Expand All @@ -28,7 +28,7 @@
"typescript": "^5.1.6",
"vite": "^6.1.0",
"vite-tsconfig-paths": "^4.2.1",
"wrangler": "^4.2.0"
"wrangler": "^4.7.1"
},
"engines": {
"node": ">=20.0.0"
Expand Down
2 changes: 0 additions & 2 deletions playground/vite-plugin-cloudflare/wrangler.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,5 @@ name = "react-router-app"
compatibility_date = "2025-03-17"
main = "./workers/app.ts"

assets = {}

[vars]
VALUE_FROM_CLOUDFLARE = "Hello from Cloudflare"
Loading