fix(prerender): use Vite base as default basename - #15379
Open
wanxiankai wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15350
What changed
baseas the production basename when the React Routerbasenameis left at its default./app/.Why
In v8, the prerender preview server is served under the Vite base path, but build-time requests were still created from the default React Router basename (
/). This caused requests such as/_.datato return 404 instead of being handled under/app/.Testing
pnpm test:integration:run integration/vite-prerender-test.ts --project chromium -g "Prerenders a spa fallback"(2 passed)pnpm run typecheckpnpm run lint(0 errors)pnpm run format:checkpnpm build