Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cache user public files as immutable #10441

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

remorses
Copy link

@remorses remorses commented Jan 28, 2025

The Remix build.assetsBuildDirectory is build/client, this folder contains user public files. The serve code is caching these files as immutable which means that even if the user changes the content of a file but not the name the file it will not be revalidated.

This PR makes immutable only files generated by Remix, which contain an hash in the name. Files in public will be cached only for 1 hour instead.

Fix #9353

Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: 6c7e9f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@remix-run/serve Patch
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/fs-routes Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/route-config Patch
@remix-run/routes-option-adapter Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 28, 2025

Hi @remorses,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 29, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@remorses remorses changed the title Do not cache as immutable user public files Do not cache user public files as immutable Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re: @remix-run/serve sets high max-age and immutable cache header on everything
1 participant