Fix unhandled rejections when aborting blocking frames - #11654
Open
brookslybrand wants to merge 1 commit into
Open
Fix unhandled rejections when aborting blocking frames#11654brookslybrand wants to merge 1 commit into
brookslybrand wants to merge 1 commit into
Conversation
Contributor
Preview Build AvailableA preview build has been created for this PR. You can install it using: pnpm install "remix-run/remix#preview/pr-11654&path:packages/remix"This preview build will be updated automatically as you push new commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aborting
renderToStreamwhile a page has multiple blockingFrames can reject all frame promises at once. Because blocking frames are awaited in tree order, the first rejection stops traversal and leaves later promises unhandled, which can crash a Node server.Observe each blocking frame promise when it is created while retaining the original promise for normal resolution and error handling. This matches the non-blocking frame handling added in #11431.