Fix timer session rounding#184
Closed
cb341 wants to merge 4 commits into
Closed
Conversation
cb341
force-pushed
the
fix/19656-timer-session-overlap
branch
from
dce155f to
d988745
Compare
cb341
force-pushed
the
fix/19656-timer-session-overlap
branch
from
bb1d5cf to
bf9cbdc
Compare
cb341
commented
Jun 30, 2025
| end | ||
|
|
||
| test 'round_timer_to_nearest_minute' do | ||
| @timer_session.timer_end = nil |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| @timer_session.timer_end = nil |
Comment on lines
+112
to
+113
| timer_session = FactoryBot.build(:timer_session, user: User.current, finished: false) | ||
| timer_session.timer_end = nil |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| timer_session = FactoryBot.build(:timer_session, user: User.current, finished: false) | |
| timer_session.timer_end = nil | |
| timer_session = FactoryBot.build(:timer_session, user: User.current, finished: false, timer_end: nil) |
|
|
||
| test 'round_timer_to_nearest_minute' do | ||
| @timer_session.timer_end = nil | ||
| timer_start_before = @timer_session.timer_start |
Contributor
Author
There was a problem hiding this comment.
hardcode seconds in the spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET-19656
The order of the before save hooks was incorrect.
Also there was an error within the
#round_timer_to_nearest_minutemethod.After some manual testing, I could not reproduce the overlaps.