fix(common): parse numeric string EVM chain IDs#5692
Open
daixihegu wants to merge 1 commit into
Open
Conversation
Signed-off-by: daixihegu <daixihegu@163.com>
🦋 Changeset detectedLatest commit: e2cf88c The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
All contributors have signed the CTA ✍️ ✅ |
|
@daixihegu is attempting to deploy a commit to the Reown Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
I have read the CTA Document and I hereby sign the CTA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
NetworkUtil.parseEvmChainIdto support numeric string chain IDs such as"1"and"42".Previously, numeric strings were treated like CAIP network IDs and returned
NaN. The helper now preserves existing CAIP parsing for values likeeip155:1, returns numeric inputs as-is, and parses non-CAIP string chain IDs withNumber(...).Type of change
Associated Issues
N/A
Showcase (Optional)
N/A - utility-only change.
Checklist