Enable fully switching to rustls#108
Open
mtkennerly wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates relay_client dependency features to explicitly control reqwest TLS backends and reduce default reqwest feature enablement.
Changes:
- Extend crate features to toggle
reqwestTLS backend alongsidetokio-tungstenite. - Disable
reqwestdefault features and explicitly opt into a smaller feature set (json,http2, etc.).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+9
| default = ["tokio-tungstenite/native-tls", "reqwest/default-tls"] | ||
| rustls = ["tokio-tungstenite/rustls-tls-native-roots", "reqwest/rustls-tls"] |
Author
There was a problem hiding this comment.
Added reqwest/rustls-tls-native-roots in 8a1fc2f to align with the existing tokio-tungstenite/rustls-tls-native-roots.
Comment on lines
+8
to
+9
| default = ["tokio-tungstenite/native-tls", "reqwest/default-tls"] | ||
| rustls = ["tokio-tungstenite/rustls-tls-native-roots", "reqwest/rustls-tls"] |
Author
There was a problem hiding this comment.
This is the existing pattern in the project, so I didn't want to introduce a breaking change here.
…io-tungstenite/rustls-tls-native-roots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi! I noticed that the
rustlsfeature doesn't fully disable OpenSSL, because it's included in the default features for reqwest 0.12 (https://github.com/seanmonstar/reqwest/blob/v0.12.28/Cargo.toml#L37 viadefault-tls). This change just disables reqwest's default features, then explicitly re-enables the necessary ones depending on the selected relay_client features. There's no change in behavior for anyone using relay_client's default features.How Has This Been Tested?
rustlsfeature in a private project where the build environment does not include OpenSSL (also usingdefault-features = falsefor relay_client)Due Diligence