chore(app): add config values types #2486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
previously approved these changes
Jul 15, 2025
JGAntunes
force-pushed
the
chore/add-config-values-types
branch
from
03ece9b to
70dc2a7
Compare
emosbaugh
previously approved these changes
Jul 15, 2025
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
emosbaugh
force-pushed
the
chore/add-config-values-types
branch
from
a0eadf6 to
f079e81
Compare
sgalsaleh
reviewed
Jul 15, 2025
| @@ -125,7 +127,12 @@ const ConfigurationStep: React.FC<ConfigurationStepProps> = ({ onNext }) => { | |||
| // Initialize configValues with initial values when they load | |||
| useEffect(() => { | |||
| if (apiConfigValues && Object.keys(configValues).length === 0) { | |||
| setConfigValues(apiConfigValues); | |||
| // Convert AppConfigValues to Record<string, string> for local state | |||
There was a problem hiding this comment.
why not make local state the same type though?
emosbaugh
reviewed
Jul 15, 2025
| @@ -13,7 +13,11 @@ func (c *InstallController) GetAppConfig(ctx context.Context) (kotsv1beta1.Confi | |||
| return c.appConfigManager.GetConfig() | |||
| } | |||
|
|
|||
| func (c *InstallController) PatchAppConfigValues(ctx context.Context, values map[string]string) (finalErr error) { | |||
| func (c *InstallController) PatchAppConfigValues(ctx context.Context, values types.AppConfigValues) (finalErr error) { | |||
| if err := c.validateReleaseData(); err != nil { | |||
There was a problem hiding this comment.
was this intentionally added back?
api/controllers/linux/install/app.go
Outdated
| @@ -13,7 +13,11 @@ func (c *InstallController) GetAppConfig(ctx context.Context) (kotsv1beta1.Confi | |||
| return c.appConfigManager.GetConfig() | |||
| } | |||
|
|
|||
| func (c *InstallController) PatchAppConfigValues(ctx context.Context, values map[string]string) (finalErr error) { | |||
| func (c *InstallController) PatchAppConfigValues(ctx context.Context, values types.AppConfigValues) (finalErr error) { | |||
| if err := c.validateReleaseData(); err != nil { | |||
There was a problem hiding this comment.
was this intentionally added back?
sgalsaleh
previously approved these changes
Jul 15, 2025
sgalsaleh
approved these changes
Jul 15, 2025
|
Failures are flakes and unrelated. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a config value type which allows us to extend value with metadata. This is required for the file input type which will hold the filename besides the actual file content in the Value property.
This is just a straight replacement change, no new functionality is added besides the filename field (and the new types) which is currently unused.
Which issue(s) this PR fixes:
Part of: https://app.shortcut.com/replicated/story/126680/add-file-config-item-type-backend-foundation
Does this PR require a test?
NONE
Does this PR require a release note?
Does this PR require documentation?
NONE