-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(window): improve rename file process and remove windows release #1728
Conversation
966423f
to
828d6ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We have to remove this as well
troubleshoot/internal/util/util.go
Line 24 in fb0f81d
return os.Getenv("USERPROFILE") // windows |
troubleshoot/pkg/longhorn/util/iscsi.go
Lines 1 to 2 in 08a1075
//go:build !windows | |
// +build !windows |
Good catch > troubleshoot/internal/util/util.go Line 24 in fb0f81d
For |
Description, Motivation and Context
sc-114325
Checklist
Does this PR introduce a breaking change?