Skip to content

Conversation

DexterYan
Copy link
Contributor

@DexterYan DexterYan commented Feb 4, 2025

Description, Motivation and Context

  • close read tmp file process before rename or redact any tmp file process
  • remove windows release binary
  • remove unused windows test and krew code

sc-114325

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@DexterYan DexterYan added type::bug Something isn't working bug::normal labels Feb 4, 2025
@DexterYan DexterYan requested a review from a team as a code owner February 4, 2025 00:47
@DexterYan DexterYan marked this pull request as draft February 4, 2025 00:47
@DexterYan DexterYan changed the title WIP fix(window): improve rename and redact file process fix(window): improve rename file process and remove windows release Feb 4, 2025
@DexterYan DexterYan marked this pull request as ready for review February 4, 2025 04:02
@DexterYan DexterYan force-pushed the dx/sc-114325/fix-rename-process branch from 966423f to 828d6ed Compare February 4, 2025 21:22
Copy link
Member

@nvanthao nvanthao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We have to remove this as well

return os.Getenv("USERPROFILE") // windows

//go:build !windows
// +build !windows

@DexterYan
Copy link
Contributor Author

LGTM

We have to remove this as well

return os.Getenv("USERPROFILE") // windows

//go:build !windows
// +build !windows

Good catch >

return os.Getenv("USERPROFILE") // windows

For //go:build !windows, it means those file will be compiled only on non-Windows platforms. I have remove pkg/longhorn/util/iscsi_windows.go

@DexterYan DexterYan requested a review from nvanthao February 11, 2025 03:25
@DexterYan DexterYan merged commit 6833915 into main Feb 11, 2025
22 checks passed
@DexterYan DexterYan deleted the dx/sc-114325/fix-rename-process branch February 11, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug::normal type::bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants