-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1287 remote rsd search (RSD v3) #1356
base: main
Are you sure you want to change the base?
Conversation
d464617
to
0820384
Compare
624569c
to
958b429
Compare
The fetching of the remote RSD name seems to be a bit buggy? When I add the dev server URL, the remote RSD name does not show up automatically. Instead I have to click the "remote control icon" first. Why not fetch it and allow the admin to change it later? After fetching the name, the text box containing it seems messed up? Also, the save icon is still disabled. When clicking on the name text box, it is cleaned up, but the save is still disabled. Clicking on the update interval or URL box activates the save button. |
When selecting by keyword, the selected keyword does not always show up. For example, when harvesting from the RSD SAAS and Helmholtz RSD, selecting "3D" works as expected: However, if I select "Data Analysis" instead, the filter works as expected, but isn't shown in the sidebar: All others I've tried seem to work as expected, so I'm not sure what the problem is with this one? |
899a3a1
to
31a253e
Compare
@jmaassen Well spotted! I have fixed both remarks. I did force push so please remote old branch and pull again. |
98b8734
to
6dc2778
Compare
@cmeessen Thanks for notifying us. It seems that rsd-dev api failed for uknown reason. I restarted docker-compose and the rsd-dev is working now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, I have some comments on the database setup.
Using the global search does not include the results from remote RSDs. |
f33951c
to
3354d83
Compare
1e54718
to
1940141
Compare
feat: add remote_rsd_name env variable to communicate RSD name to remotes
fix: keywords filter variation of the same value
docs: upgrade docusaurus to v3.6 and use rspack to speedup compilation deployment: update docker-compose.yml file of deployment to include RSD_REMOTE_NAME env variable
… using env variable
chore: upgrade next to the latest version
chore: upgrade dnd-kit to latest major versions and fix errors
…it and e2e tests chore: upgrade e2e libraries (playwright)
e869677
to
40da42e
Compare
40da42e
to
6ee4dc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When there are no entires in
rsd_info
(because they were directly deleted in the database), the Add button is not there. - I would also make the
remote_name
entry fully mutable (don't disable the slider and delete button). - The database enforces the
label
ofremote_rsd
to be of at least length 3, but the frontend form doesn't show this. - The software overview page doesn't handle a missing
remote_name
gracefully: it shows a blank entry in the filter and when you click on it, it shows nothing with anull
in the URL bar in thesources
parameter.
Once the remote_name property is set, it cannot be unset, only changed. While this is not necessarily a problem, the behavior of the tab is a bit strange. Initially the value is set: I select it: Press delete. The value is deleted: Navigate away from the box, the value is restored (which is okay): Next time I click on the value, it is highlighted dark red: If I navigate away the highlight disappears. Next selection works normally: |
When I change a value in the RSD info tab, while it it red, it appears to be stored but isn't. I start with a valid value: Then select and delete it: The value is restored: When I click it, the value turns read. I change it: The value seems stored: However, when I click and delete it again, the original value is restored, not the changed one: |
The technical documentation for the RSD info tab is still missing I think? |
9cccfd4
to
1eac6b1
Compare
… value docs: update documentation to new rsd info approach about remotes.
1eac6b1
to
de7a65b
Compare
Quality Gate passed for 'rsd-database'Issues Measures |
Quality Gate passed for 'scrapers'Issues Measures |
Quality Gate passed for 'rsd-frontend'Issues Measures |
Search for software in multiple RSD instances
Closes #1287
Changes proposed in this pull request:
rsd_info
table/endpoint is created to store the info about rsd instance. Basic endpoint information and remote_name property is inserted in the table.remote_name
prop is used in aggregated_software_overview.How to test:
make start
to build and generate test datadocker compose down & docker compose up
Example rsd info section
Example add remote RSD
Example remotes overview
Example software overview cards (showing source, remote icon and the additional filter)
Example software overview list (with source)
Example suggested remote RSD name (based on info received from remote)
Example global search includes domain for the remotes
PR Checklist:
docker-compose.yml