KAFKA-15045: KIP-924, expose TaskAssignor as public API #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ableegoldman
force-pushed
the
KIP-924-public-TaskAssignor
branch
2 times, most recently
from
39d1918 to
6e84c08
Compare
ableegoldman
force-pushed
the
KIP-924-public-TaskAssignor
branch
from
6e84c08 to
fd7204c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a bit of WIP, though the API bits are mostly done and now I'm just hacking through plugging it into the StreamsPArtitionAssignor to convince myself we're not missing any gotcha's in these messy classes