Disable async processing when thread pool size is 0 via static gate #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Too risky -- we're advise users branch their DSL operators based on their configuration in their own code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to pull/306
Unfortunately the approach taken in the above PR gets considerably messier than the first draft showed, since we need to "shut off" the async store wrappers in addition to just the async processor itself. And unfortunately, we can't delay that until #init -- at least not as easily.
This PR is definitely very hacky and probably not a great long-term solution for a real product -- but it does solve the immediate problem in a quick and neat way.