add configs to accept license and verify it #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the following changes to integrate license verification: 1. Adds responsive.license and responsive.license.file configs to allow the user to configure their license. 2. ResponsiveKafkaStreams validates the license if the user has not configured a cloud API key. The user could technically get around the license verification by configuring a bogus key. We assume that we won't have malicious users for now, and defer a more rigorous check to a future PR. We should do the check in the background and not block starting the app so that we don't depend on our cloud for the user's application to run. 3. Moves around some of the test license files so that we can use them from different tests.
agavra
approved these changes
Nov 18, 2024
Contributor
agavra
left a comment
agavra
left a comment
There was a problem hiding this comment.
I feel like now that we have this all of our integration tests will fail, we probably need to add something to ResponsiveExtension so that it will use a test licensek ey
| @@ -0,0 +1 @@ | |||
| {"keys": []} No newline at end of file | |||
Contributor
There was a problem hiding this comment.
I guess when we create the keys well update it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the following changes to integrate license verification: