API: fill in missing Mongo Window range queries #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
approved these changes
Nov 19, 2024
Contributor
agavra
left a comment
agavra
left a comment
There was a problem hiding this comment.
LGTM, though some sort of testing to make sure it's at least functional would be good 🌷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fills in some of the missing range queries we had left out of the Mongo implementation due to performance concerns. Also adds a compound index on the windowed key which should alleviate the concerns for all but one of the range query types. For this last type, we log a warning and include a suggestion for flipping a config to trade off between different range query's performance