Add retry logic for RS3 get/getoffsets requests #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodesai
reviewed
Feb 11, 2025
Contributor
rodesai
left a comment
rodesai
left a comment
There was a problem hiding this comment.
Overall the approach LGTM. Couple of minor comments inline.
kafka-client/src/test/java/dev/responsive/kafka/internal/db/rs3/RS3KVTableTest.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| public static class Connector { |
Contributor
There was a problem hiding this comment.
this is added so that we have a hook to plug in a mock?
Contributor
Author
There was a problem hiding this comment.
Added mainly because there are more parameters now. The static connect worked nicely when there were only two parameters, but it started feeling a little clumsy with the additions from the patch. Having a place to hook in mocks could be useful as well I guess.
...client/src/test/java/dev/responsive/kafka/internal/db/rs3/client/grpc/GrpcRS3ClientTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get requests are probably the simplest to retry, so I've started there. This patch adds a new
responsive.rs3.retry.timeout.msand uses exponential backoff logic (borrowed from Kafka) to retry after UNAVAILABLE errors from the rs3 server.