Introduce RS3ConfigSetter #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ableegoldman
force-pushed
the
RS3-RS3ConfigSetter
branch
from
4172ec4 to
58e01cb
Compare
hachikuji
reviewed
May 2, 2025
| * | ||
| * @return the configs to override for this store | ||
| */ | ||
| RS3StoreParams windowStoreConfig(String storeName, WindowSchema schema); |
Contributor
There was a problem hiding this comment.
Perhaps we could return a more specific type (e.g. RS3WindowStoreParams) in case there are different configurations for the respective store?
Contributor
Author
There was a problem hiding this comment.
yeah, that's probably the right thing to do...I considered that but ended up consolidating them to reduce API surface. But the problem with a generic RS3StoreParams is that it's up to the user to use the correct base/default configs for the given store type. Which will only become worse if we do have different configs for different store types in the furure
i'll go back to the store-specific params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #453 to make the filterBitsPerKey (and any future rs3/storage related settings) configurable by users for individual stores