add wiring for creating checkpoints of responsive kv stores #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- integrate with rs3 protocol for checkpoint creation - rs3 store takes checkpoints - can take a checkpoint from registration
rodesai
commented
May 7, 2025
| @JsonProperty("storeId") final UUID storeId, | ||
| @JsonProperty("pssId") final int pssId, | ||
| @JsonProperty("checkpoint") StorageCheckpoint checkpoint, | ||
| @JsonProperty("slateDbStorageCheckpoint") |
Contributor
Author
There was a problem hiding this comment.
I'll clean this up in a follow-up. My original patch had it structured so there would be a separate field for different potential storage types rather than a type hierarchy. I left the slatedb field in since I have a bunch of checkpoints lying around that I still want to be able to deserialize, and at the same time would like to start rebasing my snapshot branch on this pr (and later prs) as they get merged to main
hachikuji
approved these changes
May 8, 2025
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
LGTM. Just a few small suggestions.
kafka-client/src/main/java/dev/responsive/kafka/internal/db/rs3/TableCheckpoint.java
Show resolved
Hide resolved
kafka-client/src/main/java/dev/responsive/kafka/internal/db/rs3/client/grpc/GrpcRS3Client.java
Outdated
Show resolved
Hide resolved
kafka-client/src/main/java/dev/responsive/kafka/internal/db/rs3/client/grpc/GrpcRs3Util.java
Show resolved
Hide resolved
kafka-client/src/main/java/dev/responsive/kafka/internal/db/rs3/client/grpc/GrpcRS3Client.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds wiring for taking checkpoints from ResponsiveKafkaStreams
PssCheckpoint, which the kv table aggregates into aTableCheckpoint. This type is then serialized and returned byKVTable.checkpointResponsiveStoreRegistryis extended to support taking checkpoints from registered stores