-
Notifications
You must be signed in to change notification settings - Fork 78
feat: update PHPStan lvl to 5 #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
7dfe886
to
9ce7944
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a couple of type changes you can have a look at #92. Or wait until that one is in. It should make a couple things easier.
2fa54aa
to
546e5a0
Compare
feat: PHPStan l5
546e5a0
to
b195deb
Compare
Updated based on the latest state of the develop branch. |
For the one remaining failure, it looks like the documentation for I think adjusting that to |
I won't stop you from pushing ahead here, but I feel like scope-creep is setting in 🙂 |
I think it was mostly editing in the web UI that made it seem bad. I've covered everything now, except the fact that |
With a type hint that doesn't include an uninitialized value as an option, it can't assume |
Yeah, I had that until #91 (comment) |
I'll check it some more. Especially in newer PHP versions the assumption of "unitinitialized == null" is no longer true, that's why I don't think adding a type hint for it is correct. But maybe it's the simplest solution. |
This updates the PHPStan check to lvl 5. There are still some unresolved issues and the method types are based on the redis docs so might not be complete.