bump handlebars dependency from 4.3.1 to 4.5.0 #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a build warning due to incompatible versions of slf4j. Change in HandlebarsTemplateEngine is due to a change in handlebars where they no longer shade commons text in their jar. Exclude the nashhorn-core dependency from handlebars since it is not license compliant. It is only needed for javascript support in templates which we do not use.
djarnis73
force-pushed
the
bump-handlebars-dependency
branch
from
c759511 to
096de5d
Compare
sdk-api-gen-common/src/main/java/dev/restate/sdk/gen/template/HandlebarsTemplateEngine.java
Show resolved
Hide resolved
slinkydeveloper
approved these changes
Nov 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a build warning due to incompatible versions of slf4j.
Change in HandlebarsTemplateEngine is due to a change in handlebars where they no longer shade commons text in their jar.
This breaks the licens check, but I don't know the implications.