Skip to content

fix: destroyed async/await handler #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: destroyed async/await handler #1937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3898a55
fix: destroyed async/await handler
misyuari Dec 16, 2022
3eb0053
add test
misyuari Feb 16, 2023
1b6d4ca
Merge branch 'master' into fix-destroyed-async-await-handler
misyuari Feb 16, 2023
be11ab1
Merge branch 'master' of github.com:restify/node-restify into fix-des…
misyuari Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/chain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ Chain.prototype.run = function run(req, res, done) {
var handler = self._stack[index++];

// all done or request closed
if (!handler || req.connectionState() === 'close') {
if (!handler || req.connectionState() === 'close' || res.destroyed) {
process.nextTick(function nextTick() {
return done(err, req, res);
});
Expand Down
19 changes: 19 additions & 0 deletions test/server.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3057,3 +3057,22 @@ test('should use custom function for error handling', function(t) {
});
});
});

test('should stop the chain when response already destroyed', function(t) {
let counter = 0;
SERVER.get(
'/test',
async function test(req, res) {
counter++;
res.send();
},
async function test(req, res) {
counter++;
res.send();
}
);
CLIENT.get('/test', function() {
t.equal(counter, 1);
t.end();
});
});