Conversation
thboileau
force-pushed
the
2.6_jetty-http2-http3
branch
from
e15ec0d to
7d30753
Compare
jlouvel
reviewed
Apr 6, 2025
Collaborator
jlouvel
left a comment
jlouvel
left a comment
There was a problem hiding this comment.
Looks great overall, a few minor comments added
| * <tr> | ||
| * <td>http.transport.mode</td> | ||
| * <td>string</td> | ||
| * <td>http1</td> |
Collaborator
There was a problem hiding this comment.
@thboileau Could we use "HTTP1_1" and "HTTP2" for consistency with the protocol version and client-side parameter?
| * <tr> | ||
| * <td>http.transport.protocols</td> | ||
| * <td>string</td> | ||
| * <td>http1</td> |
Collaborator
There was a problem hiding this comment.
Same comment about "HTTP1_1"
| * @return a keystore. | ||
| * @throws Exception | ||
| */ | ||
| private static KeyStore loadKeyStore(String path, String provider, String type, char[] password) throws Exception { |
Collaborator
There was a problem hiding this comment.
Could this method be non static and protected to allow overridding?
thboileau
commented
Apr 6, 2025
|
|
||
| @Override | ||
| public void stop() throws Exception { | ||
| getLogger().info("Stopping the Jetty " + getProtocols() + " server on port " + getHelped().getPort()); |
Contributor
Author
There was a problem hiding this comment.
hi @jlouvel I see that the number of spaces for a tab is 8 with my Eclipse installation.
Do you see the same?
jlouvel
approved these changes
Apr 6, 2025
jlouvel
approved these changes
Apr 23, 2025
Collaborator
jlouvel
left a comment
jlouvel
left a comment
There was a problem hiding this comment.
Looks good to me @thboileau
added 3 commits
April 26, 2025 19:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim
Currently only the support of http2
Check-list
DO NOT REVIEW