Use client encoding as fallback (#1693)

restsharp · Jan 11, 2022 · 82d0784 · 82d0784
1 parent c7eebdf
commit 82d0784
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/RestSharp/Response/ResponseHandling.cs b/src/RestSharp/Response/ResponseHandling.cs
@@ -18,9 +18,9 @@
 namespace RestSharp;
 
 static class ResponseHandling {
-    public static string GetResponseString(this HttpResponseMessage response, byte[] bytes) {
+    public static string GetResponseString(this HttpResponseMessage response, byte[] bytes, Encoding clientEncoding) {
         var encodingString = response.Content.Headers.ContentType?.CharSet;
-        var encoding       = encodingString != null ? TryGetEncoding(encodingString) : Encoding.Default;
+        var encoding       = encodingString != null ? TryGetEncoding(encodingString) : clientEncoding;
         return encoding.GetString(bytes);
 
         Encoding TryGetEncoding(string es) {

diff --git a/src/RestSharp/Response/RestResponse.cs b/src/RestSharp/Response/RestResponse.cs
@@ -14,6 +14,7 @@
 
 using System.Diagnostics;
 using System.Net;
+using System.Text;
 using RestSharp.Extensions;
 
 // ReSharper disable SuggestBaseTypeForParameter
@@ -61,6 +62,7 @@ public class RestResponse : RestResponseBase {
     internal static async Task<RestResponse> FromHttpResponse(
         HttpResponseMessage httpResponse,
         RestRequest         request,
+        Encoding            encoding,
         CookieCollection    cookieCollection,
         CancellationToken   cancellationToken
     ) {
@@ -71,7 +73,7 @@ async Task<RestResponse> GetDefaultResponse() {
             using var stream   = await readTask.ConfigureAwait(false);
 
             var bytes   = stream == null ? null : await stream.ReadAsBytes(cancellationToken).ConfigureAwait(false);
-            var content = bytes == null ? null : httpResponse.GetResponseString(bytes);
+            var content = bytes == null ? null : httpResponse.GetResponseString(bytes, encoding);
 
             return new RestResponse {
                 Content           = content,

diff --git a/src/RestSharp/RestClient.Async.cs b/src/RestSharp/RestClient.Async.cs
@@ -31,6 +31,7 @@ public async Task<RestResponse> ExecuteAsync(RestRequest request, CancellationTo
             ? await RestResponse.FromHttpResponse(
                     internalResponse.ResponseMessage!,
                     request,
+                    Options.Encoding,
                     CookieContainer.GetCookies(internalResponse.Url),
                     cancellationToken
                 )