This repository was archived by the owner on Mar 10, 2026. It is now read-only.
Prefer Electron shell before Linux opener fallback for external URLs#30
Merged
Prefer Electron shell before Linux opener fallback for external URLs#30
Conversation
- try `shell.openExternal` first on Linux - fall back to Linux opener only if Electron shell throws - add tests for Linux success, fallback, and dual-failure paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openExternalUrlto try Electronshell.openExternalfirst on all platforms.falsewhen Electron shell fails).Testing
apps/desktop/src/openExternal.test.tscovering:falsewhen both openers fail.bun lint: Not runbun typecheck: Not run