Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

Stabilize ChatView browser tests for virtualization and first-send handshake#37

Merged
rexlManu merged 1 commit intomainfrom
t3code/update-outdated-browser-tests
Mar 9, 2026
Merged

Stabilize ChatView browser tests for virtualization and first-send handshake#37
rexlManu merged 1 commit intomainfrom
t3code/update-outdated-browser-tests

Conversation

@rexlManu
Copy link
Copy Markdown
Owner

@rexlManu rexlManu commented Mar 9, 2026

Summary

  • update ChatView browser test names to better reflect behavior under test (virtualized timeline rendering, first-send handshake, burst event handling)
  • replace brittle estimator-parity assertions with stronger runtime invariants for virtualized rows (renderedInVirtualizedRegion, positive timeline width, and large measured row height)
  • harden draft-thread handshake coverage by asserting thread.create and thread.turn.start dispatches while route/draft state remain stable
  • reduce flaky burst-event expectations by asserting stable UI presence and bounding snapshot refresh requests (<= 1)

Testing

  • Not run (PR content generated from provided diff)
  • recommended checks:
  • bun lint
  • bun typecheck
  • bun run test apps/web/src/components/ChatView.browser.tsx

- Relax brittle height parity assertions to resilient render/size checks
- Verify draft-thread first-send handshake by asserting dispatched commands
- Tighten burst event test wording and bound snapshot refresh expectations
@rexlManu rexlManu merged commit e4dd5d0 into main Mar 9, 2026
1 check failed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant