This repository was archived by the owner on Mar 10, 2026. It is now read-only.
Conversation
- Search `apps/` recursively for web app roots and favicon candidates on the server - Return `204` instead of serving an SVG fallback when no favicon exists - Update sidebar favicon rendering to reset load state per project and use icon fallback reliably
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
favicon-16x16/favicon-32x32) and icon link parsing from source files.apps/search to resolve favicons from nested web app roots while skipping build/cache directories.204 No Contentwhen no favicon exists.ProjectFaviconto reset loading state whencwdchanges, validate loaded image dimensions, and support a configurable fallback icon.Testing
apps/web/public/favicon.ico.index.htmlicon link.204response when no favicon is found.bun lint: Not runbun typecheck: Not run