trivial cleanups #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason A. Donenfeld <[email protected]>
Unused variable, signed/unsigned comparison. Signed-off-by: Jason A. Donenfeld <[email protected]>
clang-analyzer complains about sockaddr_storage being uninitalized, so we zero that out first. Then, while we're at it, we use the right constants for getnameinfo output sizes, and note the fact that the null byte is part of snprintf's calculations. Signed-off-by: Jason A. Donenfeld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cool project! I'll do a full read through this week, but for now, here are just the most trivial cleanups that didn't involve reading actual code.