Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerization of the project and the ability to publish it in IPM #6

Closed
wants to merge 2 commits into from

Conversation

SergeyMi37
Copy link

No description provided.

Copy link
Owner

@rfns rfns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Ah, sorry for the wait and thanks for your contribution. I've been busy with other stacks due to my job, so lately so I can't always find a time to delve back into Caché/IRIS like before.

I updated the pipeline with the latest version of iris-ci. So please make sure to provide regression tests for the enhancement you implemented with the method below then validate my suggestions and you're ready to go!

ClassMethod CreateArray(out As %Stream.Object, env) As %ArrayOfDataTypes [ Internal ]
{
set envs = ##class(%ArrayOfDataTypes).%New()
if '$isobject(out) quit envs
while 'out.AtEnd {
set line = out.ReadLine()
continue:line=""
set envName = $piece(line, "=")
set envValue = $piece(line, "=", 2, *)
if $extract(envValue) = $char(34) && ($extract(envValue, *) = $char(34)) {
set envValue = $zconvert($extract(envValue, 2, *-1), "I", "JS")
}
do envs.SetAt(envValue, envName)
set env(envName) = envValue
}
quit envs
}

Also, please feel free to advertise some repos using the README, including yours. I recognized that we need to gather more attention from the community as a whole since ObjectScript is not exactly a language of easy access due to its nature and overall purpose.

README.md Show resolved Hide resolved
module.xml Show resolved Hide resolved
cls/DotEnv/Parser.cls Show resolved Hide resolved
@@ -33,7 +33,7 @@ ClassMethod FromPath(path As %String, Output sc As %Status = {$$$OK}, dotenv As
quit envs
}

ClassMethod CreateArray(out As %Stream.Object) As %ArrayOfDataTypes [ Internal ]
ClassMethod CreateArray(out As %Stream.Object, env) As %ArrayOfDataTypes [ Internal ]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ClassMethod CreateArray(out As %Stream.Object, env) As %ArrayOfDataTypes [ Internal ]
ClassMethod CreateArray(out As %Stream.Object, Output env) As %ArrayOfDataTypes [ Private ]

@@ -3,11 +3,11 @@ Include %occStatus
Class DotEnv.Parser [ Abstract ]
{

ClassMethod FromOS(Output sc As %Status = {$$$OK}) As %ArrayOfDataTypes
ClassMethod FromOS(Output sc As %Status = {$$$OK}, ByRef env ) As %ArrayOfDataTypes
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ClassMethod FromOS(Output sc As %Status = {$$$OK}, ByRef env ) As %ArrayOfDataTypes
ClassMethod FromOS(Output sc As %Status = {$$$OK}, ByRef env) As %ArrayOfDataTypes

docker-compose.yml Show resolved Hide resolved
iris.script Show resolved Hide resolved
Copy link
Owner

@rfns rfns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to change the option. 🤷

@rfns rfns added this to the v1.1.0 milestone Apr 3, 2024
@SergeyMi37
Copy link
Author

Okay, thank you for the detailed analysis of my modest contribution to your project.

@rfns
Copy link
Owner

rfns commented Jul 30, 2024

Closed due to inactivity. Feel free to reopen or request it if you want to continue.

@rfns rfns closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants