Bulk import workflow sample#774
Merged
elai-shalev merged 14 commits intorhdhorchestrator:mainfrom Mar 22, 2026
Merged
Conversation
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
elai-shalev
reviewed
Mar 19, 2026
Collaborator
elai-shalev
left a comment
elai-shalev
left a comment
There was a problem hiding this comment.
Overall workflow looks great, not issue to merge it.
one question about the change to the pipeline dockerfile
Comment on lines
+171
to
+177
| @# Ensure WORKDIR exists and is accessible (important for macOS Podman) | ||
| @test -d $(WORKDIR) || mkdir -p $(WORKDIR) | ||
| @# Use absolute path for volume mount (required for Podman on macOS) | ||
| @# On macOS, use realpath or fallback to WORKDIR if realpath fails | ||
| @$(CONTAINER_ENGINE) run --rm -v "$(shell realpath $(WORKDIR) 2>/dev/null || echo $(WORKDIR)):/workdir:Z" -w /workdir \ | ||
| $(LINUX_IMAGE) /bin/bash -c "ENABLE_PERSISTENCE=$(ENABLE_PERSISTENCE) WORKFLOW_IMAGE_TAG=$(IMAGE_TAG) ${SCRIPTS_DIR}/gen_manifests.sh $(GEN_MANIFESTS_WORKFLOW_FOLDER) $(WORKFLOW_ID)" | ||
| @echo "Manifests are available in workdir $(WORKDIR)/$(GEN_MANIFESTS_WORKFLOW_FOLDER)/manifests" |
elai-shalev
reviewed
Mar 19, 2026
Comment on lines
43
to
44
| ENV swf_home_dir=/home/kogito/serverless-workflow-project | ||
| RUN if [[ -d "./resources/src" ]]; then cp -r ./resources/src/* ./src/; fi | ||
|
|
Collaborator
There was a problem hiding this comment.
why was this line removed?
Contributor
Author
There was a problem hiding this comment.
RUN if [[ -d "./resources/src" ]]; then cp -r ./resources/src/* ./src/; fiThis command copies files from
/home/kogito/serverless-workflow-project/resources/src
to the
/home/kogito/serverless-workflow-project/src:
After that we have workflow file
/home/kogito/serverless-workflow-project/src/main/resources/create-pr-universal.sw.yaml
inside container.
That's OK, but build-app.sh script also copies files...
Next Dockerfile command:
RUN /home/kogito/launch/build-app.sh ./resourcesFragment of this script:
...
destination="${KOGITO_HOME}/serverless-workflow-project/src/main/resources/"
log_info "-> Destination folder is ${destination}"
cp -vR ${resources_path}/* ${destination}
...
And build image log for this command
INFO -> Destination folder is /home/kogito/serverless-workflow-project/src/main/resources/
'/home/kogito/serverless-workflow-project/resources/src/main/resources' -> '/home/kogito/serverless-workflow-project/src/main/resources/src/main/resources'
'/home/kogito/serverless-workflow-project/resources/src/main/resources/application.properties' -> '/home/kogito/serverless-workflow-project/src/main/resources/src/main/resources/application.properties'
'/home/kogito/serverless-workflow-project/resources/src/main/resources/create-pr-universal.sw.yaml' -> '/home/kogito/serverless-workflow-project/src/main/resources/src/main/resources/create-pr-universal.sw.yaml'So build-app.sh provides duplicated workflow file. These workflows has a bit different path:
/home/kogito/serverless-workflow-project/src/main/resources/create-pr-universal.sw.yaml
/home/kogito/serverless-workflow-project/src/main/resources/src/main/resources/create-pr-universal.sw.yaml
Then build-app.sh makes maven build and fails with "Duplicated item found with id universal-pr":
Error: Failed to execute goal com.redhat.quarkus.platform:quarkus-maven-plugin:3.15.4.redhat-00001:build (default) on project serverless-workflow-project: Failed to build quarkus application: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
Error: [ERROR] [error]: Build step org.kie.kogito.quarkus.common.deployment.KogitoAssetsProcessor#generateSources threw an exception: org.kie.kogito.codegen.process.ProcessCodegenException: Duplicated item found with id universal-pr. Please review the .sw files
elai-shalev
approved these changes
Mar 22, 2026
Collaborator
elai-shalev
left a comment
elai-shalev
left a comment
There was a problem hiding this comment.
LGTM, workflow looks good and requested changes to shared documents fixed previous issues.
Comment on lines
43
to
44
| ENV swf_home_dir=/home/kogito/serverless-workflow-project | ||
| RUN if [[ -d "./resources/src" ]]; then cp -r ./resources/src/* ./src/; fi | ||
|
|
orchestrator-ci
pushed a commit
that referenced
this pull request
Mar 22, 2026
orchestrator-ci
pushed a commit
that referenced
this pull request
Mar 22, 2026
orchestrator-ci
pushed a commit
that referenced
this pull request
Mar 22, 2026
orchestrator-ci
pushed a commit
that referenced
this pull request
Mar 22, 2026
orchestrator-ci
pushed a commit
that referenced
this pull request
Mar 22, 2026
orchestrator-ci
pushed a commit
that referenced
this pull request
Mar 22, 2026
orchestrator-ci
pushed a commit
that referenced
this pull request
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What doest this pull request fix:
https://redhat.atlassian.net/browse/RHIDP-9350