dracut: depend on net-lib not ifcfg #6157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifcfg is gone in dracut-ng 204. Looking at the module and its history, I'm pretty sure we don't actually use anything from the ifcfg module any more. anaconda-ifcfg.sh only uses save_netinfo, which is in net-lib. So let's turn the ifcfg dep into a net-lib dep instead. If I missed anything and we really are still relying on the ifcfg module then we need to fix that, since it's gone now. Resolves: rhbz#2343125
jkonecny12
approved these changes
Feb 12, 2025
|
/kickstart-test --testtype smoke |
|
Hm, let me look at the failed smoke tests. |
|
/build-image |
|
Images built based on commit 43d3e7a:
Download the images from the bottom of the job status page. |
|
/kickstart-test --testtype smoke |
Latest F42 iso works for me with the failing tests. It could be useful to build the iso here to be able to debug locally but we'd need to rebase the PR on the 2dbeea4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ifcfg is gone in dracut-ng 204. Looking at the module and its history, I'm pretty sure we don't actually use anything from the ifcfg module any more. anaconda-ifcfg.sh only uses save_netinfo, which is in net-lib. So let's turn the ifcfg dep into a net-lib dep instead.
If I missed anything and we really are still relying on the ifcfg module then we need to fix that, since it's gone now.
Resolves: rhbz#2343125
Port of PR: #6125