-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress reporting #145
base: master
Are you sure you want to change the base?
Progress reporting #145
Conversation
A bit busy right now - hopefully will be able to take a look in a week or two. Thanks! :) |
Move code to a separate task, so a subsequent commit can hook it up to a progress-reporting spoke. Besides plain code move, it uses a TaskQueue to collect tasks first, and then call them all.
Add a standalone spoke that reports progress of configuration tasks. This is heavily based on ProgressSpoke from anaconda itself, with few minor differences: - logic for "continue"/"reboot" buttons removed - automatic close on finish (as initial-setup normally does) - add basic error reporting - anaconda has elaborate exception handling machinery but initial setup doesn't; add simple try/except in the key place, so user will see the error, not a silent failure
@jkonecny12 Do you know if we should tread this as deprecated or rework and include into the code? |
FWIW, I still use this on Qubes OS, including upcoming R4.3 that has dom0 based on Fedora 41. |
Hello, unfortunately the Anaconda team doesn't have the capacity to focus on this project. We already announced some time ago our intentions to deprecate this project in Fedora and we removed the project from CentOS Stream 10. We are keeping the project alive because of IoT and similar projects but our future goal is to deprecate the project also in Fedora. I don't think it's possible for us to work on this feature. Sorry for the bad news 😔 |
@jkonecny12 if at this point we should announce archiving of this project on the main project page / readme? |
Good idea, I'll discuss this with the team. |
It's not possible to archive this project as long as almost every single Fedora variant requires it. The only one that doesn't use it is Workstation because they have their own thing with |
If you need community assistance, I'm sure we can get some folks to commit to helping out. |
FWIW we do need it at Qubes OS too, and we can help out too. But, we don't update our installer stack that often - usually every 2 years, so we skip several versions. |
Hi @marmarek - I just checked with the team and the project will remain in current state, so there are no plans to archive it right now (and in close future). Feel free to open PRs with changes you have prepared for Qubes OS. We have limited capacity but I will try to utilize some time for review:) |
For starters, this very PR :) |
For longer configure operations it's useful to provide any kind of progress. For example, in Qubes OS we use initial-setup (addon) to create default VMs (aka "qubes") which may take few minutes. Without progress reporting, this is rather frustrating to the users.
This PR adds simple progress reporting to the GUI, based on similar code in anaconda itself.
The TUI remains unchanged.
Right now, the progress spoke is always used, and closes automatically (as initial-setup did before). If it's desirable, I can probably add an option to hide the progress spoke.