Feature/41 #35
Open
Feature/41 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyasminocha
requested changes
Apr 8, 2023
| @@ -31,6 +31,8 @@ dependencies: | |||
| json_annotation: ^4.7.0 | |||
| image_stack: ^2.1.1 | |||
| flutter_svg: ^1.1.5 | |||
| flutter_dotenv: ^5.0.2 | |||
There was a problem hiding this comment.
If we're not using this dependency can we please remove it?
| } | ||
|
|
||
| Future<UserModel> fetchUser() async { | ||
| final response = await http.get(Uri.parse("$backendURL\\users\\$postUser")); |
There was a problem hiding this comment.
Is there any reason this uses \\ instead of /? The latter is more typical for paths, unless I'm missing something.
AhmedA1559
reviewed
Apr 15, 2023
| } | ||
| } | ||
|
|
||
| Future<UserModel> fetchUser() async { |
There was a problem hiding this comment.
Method should be moved out of Widget class for later usage
AhmedA1559
reviewed
Apr 15, 2023
| @@ -22,6 +25,7 @@ class _ProfileScreenState extends State<ProfileScreen> | |||
| _tabController.addListener(() { | |||
| setState(() {}); | |||
| }); | |||
| _userModel = widget.userModel; | |||
There was a problem hiding this comment.
No need to have another member variable here, using widget.userModel in the code is OK
AhmedA1559
reviewed
Apr 15, 2023
| } | ||
|
|
||
| Future<UserModel> fetchUser() async { | ||
| final response = await http.get(Uri.parse("$backendURL\\users\\$postUser")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Link from post to user profile now working
Tests Performed: linked to bananalegend
Trello Card Link: https://trello.com/c/qdxmsV4D