Issue 84

build.gradle

@@ -89,7 +89,8 @@ subprojects { proj ->
 //        }
 
         test {
-            useTestNG()
+            useJUnitPlatform()
+            //useTestNG()
             jvmArgs("-Djdk.attach.allowAttachSelf")
             testLogging.showStandardStreams = true
         }

remoting/rico-remoting-server-spring-test/rico-remoting-server-spring-test.gradle

@@ -21,6 +21,12 @@ dependencies {
     implementation "org.testng:testng:$testngVersion"
     implementation "junit:junit:$junitVersion"
 
+    testCompile("org.junit.jupiter:junit-jupiter-api:5.7.0")
+    testRuntimeOnly("org.junit.platform:junit-platform-launcher:1.7.0")
+
+    compile 'org.junit.jupiter:junit-jupiter:5.7.0'
+    compile("org.junit.jupiter:junit-jupiter-engine:5.7.0")
+
     implementation "org.springframework:spring-web:$springVersion"
     implementation "org.springframework:spring-context:$springVersion"
     implementation "org.springframework:spring-test:$springVersion"

remoting/rico-remoting-server-spring-test/src/main/java/dev/rico/internal/server/remoting/test/ClientTestFactory.java

@@ -41,6 +41,7 @@ public static <T> ControllerUnderTest<T> createController(final TestClientContex
             final ControllerProxy<T> proxy = (ControllerProxy<T>) clientContext.createController(controllerName, parameters).get();
             return new ControllerUnderTestWrapper<>(clientContext, proxy);
         } catch (Exception e) {
+            e.printStackTrace();
             throw new ControllerTestException("Can't create controller proxy", e);
         }
     }

remoting/rico-remoting-server-spring-test/src/main/java/dev/rico/server/remoting/test/SpringJUnitControllerTest.java

@@ -21,57 +21,66 @@
 import dev.rico.internal.server.remoting.test.SpringTestBootstrap;
 import dev.rico.internal.server.remoting.test.TestClientContext;
 import org.apiguardian.api.API;
-import org.junit.Rule;
-import org.junit.rules.ExternalResource;
+
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+
+
+import org.junit.jupiter.api.extension.ExtendWith;
+
+
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.annotation.DirtiesContext;
 import org.springframework.test.context.ContextConfiguration;
-import org.springframework.test.context.junit4.AbstractJUnit4SpringContextTests;
+import org.springframework.test.context.junit.jupiter.SpringExtension;
+
+
+
 
 import static org.apiguardian.api.API.Status.MAINTAINED;
 
 /**
  * Base class for JUnit based controller tests in Spring. This class can be extended to write custom controller tests.
  *
  * @see ControllerTest
- * @see AbstractJUnit4SpringContextTests
+ * @see //AbstractJUnit4SpringContextTests
  * @see ControllerUnderTest
  *
  * @author Hendrik Ebbers
  */
+
+@ExtendWith({SpringExtension.class})
 @SpringBootTest
 @ContextConfiguration(classes = SpringTestBootstrap.class)
 @DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_EACH_TEST_METHOD)
 @API(since = "0.x", status = MAINTAINED)
-public abstract class SpringJUnitControllerTest extends AbstractJUnit4SpringContextTests implements ControllerTest {
+public abstract class SpringJUnitControllerTest  implements ControllerTest {
 
     @Autowired
     private TestClientContext clientContext;
 
-    @Rule
-    public ExternalResource clientConnector = new ExternalResource() {
-        @Override
-        protected void before() throws Throwable {
-            super.before();
-            clientContext.connect().get();
-        }
 
-        @Override
-        protected void after() {
-            super.after();
-            try {
-                clientContext.disconnect().get();
-            } catch (Exception e) {
-                throw new ControllerTestException("Can not disconnect client context!", e);
-            }
+    @AfterEach
+    public void closeClient() throws Exception {
+        try {
+            clientContext.disconnect().get();
+        } catch (Exception e) {
+            throw new ControllerTestException("Can not disconnect client context!", e);
         }
-    };
+
+    }
+
+    @BeforeEach
+    public void connectClient() throws Exception {
+
+        clientContext.connect().get();
+    }
 
     public <T> ControllerUnderTest<T> createController(final String controllerName) {
         Assert.requireNonBlank(controllerName, "controllerName");
         try {
-            return ClientTestFactory.createController(clientContext, controllerName);
+            return ClientTestFactory.createController(clientContext,  controllerName);
         } catch (Exception e) {
             throw new ControllerTestException("Can't create controller proxy", e);
         }

remoting/rico-remoting-server-spring-test/src/main/java/module-info.java

@@ -14,4 +14,9 @@
     requires static java.servlet;
     requires testng;
     requires junit;
+
+    //adding junit 5 to the module
+    requires org.junit.jupiter;
+
+
 }

remoting/rico-remoting-server-spring-test/src/test/java/dev/rico/server/remoting/test/JUnitDemoTest.java

@@ -16,9 +16,8 @@
  */
 package dev.rico.server.remoting.test;
 
-import org.junit.Test;
-
-import static org.junit.Assert.*;
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.*;
 
 public class JUnitDemoTest extends SpringJUnitControllerTest {
 
@@ -68,4 +67,7 @@ public void testInvokeActionAfterDestroy() {
             fail("Calling an action after destroy should throw an exception!");
         } catch (ControllerTestException e) {}
     }
+
+
+
 }