Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle non standard currency with decoded length of 3 #1131

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

pdp2121
Copy link
Collaborator

@pdp2121 pdp2121 commented Feb 19, 2025

High Level Overview of Change

Handle non standard currency that decoded to 3 characters, putting prefix Fake to such currency.

Instead of being non-standard, 3 character currency codes should use the standard format if they are not "fake".

Context of Change

Resolve #1130

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

Before / After

Before

Screenshot 2025-02-19 at 4 06 15 PM

After

Screenshot 2025-02-19 at 4 07 00 PM

@intelliot intelliot changed the title fix: handle non standard currency with decoded length less than 4 fix: handle non standard currency with decoded length of 3 Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle non-standard currency code "XRP"
4 participants