Skip to content

Fix: Memory leak in riscv_openocd_step_impl() #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: riscv
Choose a base branch
from
Open

Fix: Memory leak in riscv_openocd_step_impl() #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51db0ca
added the necessary tests for progbufsize
Oct 26, 2025
38450ad
riscv: Add have_progbuf_size check in vtype,vl writes and crs,fpr rea…
Oct 27, 2025
8557f4f
riscv: Fix memory leak in riscv_openocd_step_impl
Oct 27, 2025
a08870a
original file _ will rebase it
Biancaa-R Oct 27, 2025
c362895
Update spike-openocd-tests.yml
Biancaa-R Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/spike-openocd-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,15 @@ jobs:
git clone "$RISCV_TESTS_REPO"
cd riscv-tests
git checkout "$RISCV_TESTS_REV"
git submodule update --init --recursive
git submodule update --init --recursive

- name: Run basic debug test under Valgrind (memory leak check)
run: |
sudo apt-get install -y valgrind
echo "Running RISC-V debug test under Valgrind for memory leak detection..."
# Run a minimal configuration to detect leaks in riscv_openocd_step_impl()
valgrind --leak-check=full --error-exitcode=1 \
./src/openocd -f tcl/interface/jtag_dummy.cfg -f tcl/target/riscv.cfg -c "init; shutdown"

- name: Run Spike32 Tests
id: spike32-tests
Expand Down
2 changes: 2 additions & 0 deletions src/target/riscv/riscv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4258,6 +4258,8 @@ static int riscv_openocd_step_impl(struct target *target, bool current,
LOG_TARGET_ERROR(target, "Failed to re-enable watchpoints "
"after single-step.");
}
free(wps_to_enable);
//no longer needed to be kept

if (breakpoint && (riscv_add_breakpoint(target, breakpoint) != ERROR_OK)) {
success = false;
Expand Down