fix(vector): reorganize vector tests and add new tests for vsetvli #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adingank-qualcomm
commented
Dec 4, 2025
adingank-qualcomm
commented
- start vset
- update vset
- start adding CSRs
- start adding CSRs
- add skeleton for remaining CSRs
- add skeleton for remaining CSRs
- update CSRs based on comments
- add remaining csr details
- update csr read in vset
- address comments
- add pretty tables in csr descriptions
- break up csr write fields in vset
- feat(idl): add constraints to IDL
- feat: add mock spec to udb gem for testing, add Condition classes
- docs: document schema conditions and idl implications
- refactor: move parameters into their own YAML files
- feat: wip
- feat: wip
- update vl assignment in ranged case
- add vxsat and vxrm sw_write
- set vill in unsupported cases
- fix idl compile errors
- adress dhower's feedback
- Update spec/std/isa/ext/V.yaml
- Update spec/std/isa/csr/V/vxsat.yaml
- Update spec/std/isa/csr/V/vxrm.yaml
- Update spec/std/isa/csr/V/vcsr.yaml
- Update spec/std/isa/inst/V/vsetivli.yaml
- adress thinkopenly's comments
- fix:(vector): restructuring vset instructions operation()
- chore: dependency update
- feat: wip
- fix: merge errors
- feat(vector): add rv32 vector configuration based on rv32-riscv-tests cfg
- wip
- feat(vector): add skeleton of vadd.vv
- wip
- add regress job dependency
- Fix path in regression for udb unit tests
- wip
- wip
- wip
- wip
- wip
- wip
- fix(vector): fix vset failures*
- wip
- wip
- wip
- wip
- wip
- feat(vector): add skeleton of vadd.vv
- fix(vector): fix vset failures*
- wip
- wip
- fix(vector): implement vadd.vv
- fix(vector): extract V parameters into their own files
- fix(vector): get iss through compilation after changes from issue 891
- fix(vector): add launch config for vsetvli debug
- fix(vector): sort param topologically w.r.t. dependence
- fix(vector): add 64 to SXLEN as a workaround to get ISS to run a test
- fix(vector): use const refs with std::find() in param_value() and defined()
- fix(vector): handle rs1==x0 case in vsetvli
- fix(vector): fix indentation in vsetvli
- feat: infrastructure to extend the riscv-tests suite without modifying ext repo
- fix: corrected copy paste errors
- fix(vector): move vector tests from ext/riscv-tests/ submodule to tests/
- fix(build): fix Gem path for bundler & ignore generated test/dump files
rebase vector branch to latest
merge rebase
Pushing a first cut to move to WSL+devbranch workflow.
In vec.idl: Added log2_sew field to enable using shifts (with correct amounts :-) Renamed log2_multiplier to log2_lmul and fixed fractional LMUL values In vset*.yaml: Read the content of xs1 (not the register number) as the value of AVL Read the content of xs2 (for vsetvl) as the value of new VTYPE In rv32-vector.yaml: Fixed name from old copy-paste; added "V extension" to description
Used concatenation to write back results. TBD: Replace with bitfield write when it's released in IDL. TBD: Remove hard coding length of Vector registers which is a work-around for a bug in using rv-vector config to build the ISS (and since rv32 config doesn't and shouldn't define VLEN parameter.
Created 4 files for params and removed the params property from V.yaml
Fixed constexpr errors and got rv32 config to build.
…ined()
Fixed the workaround for the case of a compared value not being included for
a parameter in a config, viz., 64 for SV{39,48,57}X4_TRANSLATION for rv32.
- Added vsetvli_rs1_eq_zero test to verify that vl is set to vlmax when rs1 is x0 for cases of SEW=8,32,64 and LMUL=8. - Also renamed the old vsetvli test to vsetvli_vl_lt_vlmax to reflect the intent better.
Tested Henrik's new directory structure under tests/isa/. Added new tests for vsetvli. Started adopting naming convention of <instr>_<coverage_cond> for vsetvli.
adingank-qualcomm
requested review from
ThinkOpenly and
dhower-qc
as code owners
adingank-qualcomm
changed the title
adingank-qualcomm
changed the title
adingank-qualcomm
changed the title
Collaborator
|
To make this review clearer and easier you may want to rebase vector branch onto main |
Collaborator
Actually, the issue is that the vector branch has #891 in it, so it's ahead of main. That should resolve itself when 891 merges |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.