-
Notifications
You must be signed in to change notification settings - Fork 73
Fix ERB template resolution in C header generation - Addresses PR #91… #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ERB template resolution in C header generation - Addresses PR #91… #940
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #940 +/- ##
=======================================
Coverage 43.26% 43.26%
=======================================
Files 10 10
Lines 4791 4791
Branches 1300 1300
=======================================
Hits 2073 2073
Misses 2718 2718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI failure. You just need to run pre-commit locally.
It was a mistake from my side and recommends deleting the branch and closing the PR - sorry for that... |
I'm sorry, I can't understand that. What recommends? |
you just need to run pre-commit locally: ./bin/pre-commit run that will update the file that needs a formatting fix. Then just add it and commit again: git add backends/generators/c_header/generate_encoding.py
git commit |
Ok
…On Wed, 6 Aug, 2025, 04:00 Derek Hower, ***@***.***> wrote:
*dhower-qc* left a comment (riscv-software-src/riscv-unified-db#940)
<#940 (comment)>
you just need to run pre-commit locally:
./bin/pre-commit run
that will update the file that needs a formatting fix. Then just add it
and commit again:
git add backends/generators/c_header/generate_encoding.py
git commit
—
Reply to this email directly, view it on GitHub
<#940 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLR2IIM5FYZJGDQBYRVZCJT3MEV7DAVCNFSM6AAAAACC65XJ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNJWHAZDONBQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Superceded by #1051 |
Ok
…On Thu, 18 Sept, 2025, 00:34 Paul Clarke, ***@***.***> wrote:
*ThinkOpenly* left a comment (riscv-software-src/riscv-unified-db#940)
<#940 (comment)>
Superceded by #1051
<#1051>
—
Reply to this email directly, view it on GitHub
<#940 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLR2IIOOM3WFRPC6SOJEKWT3TGWEBAVCNFSM6AAAAACC65XJ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMBUGIZDGNRTGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…7 reviewer feedback