Skip to content

Conversation

7908837174
Copy link
Contributor

…7 reviewer feedback

Copy link

codecov bot commented Aug 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.26%. Comparing base (e3b25cd) to head (7a186eb).
⚠️ Report is 58 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   43.26%   43.26%           
=======================================
  Files          10       10           
  Lines        4791     4791           
  Branches     1300     1300           
=======================================
  Hits         2073     2073           
  Misses       2718     2718           
Flag Coverage Δ
idlc 43.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@AFOliveira AFOliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI failure. You just need to run pre-commit locally.

@7908837174
Copy link
Contributor Author

It was a mistake from my side and recommends deleting the branch and closing the PR - sorry for that...

@7908837174 7908837174 requested a review from AFOliveira August 4, 2025 09:53
@AFOliveira
Copy link
Collaborator

It was a mistake from my side and recommends deleting the branch and closing the PR - sorry for that...

I'm sorry, I can't understand that. What recommends?

@dhower-qc
Copy link
Collaborator

you just need to run pre-commit locally:

./bin/pre-commit run

that will update the file that needs a formatting fix. Then just add it and commit again:

git add backends/generators/c_header/generate_encoding.py
git commit

@7908837174
Copy link
Contributor Author

7908837174 commented Aug 5, 2025 via email

@ThinkOpenly
Copy link
Collaborator

Superceded by #1051

@7908837174
Copy link
Contributor Author

7908837174 commented Sep 18, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants