Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmadc/vmsbc instruction clarification #1834

Merged
merged 1 commit into from
Jan 29, 2025
Merged

vmadc/vmsbc instruction clarification #1834

merged 1 commit into from
Jan 29, 2025

Conversation

jacassidy
Copy link
Contributor

There appears to be a typo that suggests the instruction writes back the result of the operation rather than the carry/borrow out

@jacassidy
vmadc/vmsbc instruction clarification
70bc3aa 
Appears to be a typo that suggest the instruction writes back the result of the operation rather than the carry/borrow out

Signed-off-by: jacassidy <[email protected]>
aswaterman
aswaterman approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent was that, since these instructions are described as producing a carry or borrow, "result" refers to the carry or borrow, not the sum or difference. But your version removes all doubt, so let's go with it.

@aswaterman aswaterman merged commit 72c5dfd into riscv:main Jan 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswaterman aswaterman aswaterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacassidy @aswaterman