Skip to content

feat: add clone for DataFile #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ZENOTME
Copy link

@ZENOTME ZENOTME commented Mar 5, 2025

No description provided.

@ZENOTME ZENOTME requested review from chenzl25, Li0k and xxchan March 5, 2025 09:42
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be submitted in upstream directly and it's time to do a rebase? Seems many of our PRs are merged upstream 🤔

@ZENOTME
Copy link
Author

ZENOTME commented Mar 5, 2025

There are some pr still not merge in #10. To avoid blocking other pr, let's merge it first. I will rebase later.

Can this be submitted in upstream directly and it's time to do a rebase? Seems many of our PRs are merged upstream 🤔

In upstream we serialize datafile to avro so we don't need Clone. Let's fix them after rebase.

@ZENOTME ZENOTME merged commit 3e9763d into risingwavelabs:dev_rebase_main_20241230 Mar 5, 2025
1 check passed
@ZENOTME ZENOTME deleted the rw_add_clone branch March 5, 2025 09:48
chenzl25 pushed a commit that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants