feat(iceberg): support DeleteScan for datafusion engine #24065
Merged
+229
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingzhuo Yin <[email protected]>
github-actions
bot
added
type/feature
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for DeleteScan operations (both equality and position deletes) to the DataFusion engine for Iceberg tables. Previously, only DataScan was supported. The changes enable proper handling of delete files in Iceberg's copy-on-write operations.
Key changes:
- Converted
IcebergScan::new()to an async function to support pre-loading file scan tasks during initialization - Added
list_iceberg_scan_task()method to enumerate and filter data/delete files based on scan type - Implemented metadata column appending (sequence number, file path, file position) for tracking row lineage
- Changed partition handling from single partition to multi-partition based on file scan tasks
- Removed hidden column filtering to expose Iceberg metadata columns through the DataFusion schema
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/frontend/src/datafusion/iceberg_table_provider.rs | Made scan() async and removed hidden column filter to expose Iceberg metadata columns |
| src/frontend/src/datafusion/iceberg_executor.rs | Added delete scan support with task enumeration, multi-partition execution, and metadata column handling |
| e2e_test/iceberg/test_case/pure_slt/iceberg_datafusion_engine.slt | Added test cases for delete operations with DataFusion engine |
Comments suppressed due to low confidence (1)
src/frontend/src/datafusion/iceberg_executor.rs:64
- The
#[allow(dead_code)]attributes onneed_seq_numandneed_file_path_and_posare no longer needed as these fields are now actively used in theexecute_innermethod (lines 265-266). These attributes should be removed.
need_seq_num: bool,
#[allow(dead_code)]
need_file_path_and_pos: bool,
Signed-off-by: Mingzhuo Yin <[email protected]>
Signed-off-by: Mingzhuo Yin <[email protected]>
chenzl25
reviewed
Dec 12, 2025
| plan_properties, | ||
| }; | ||
| inner.tasks = inner.list_iceberg_scan_task().try_collect().await?; | ||
| inner.plan_properties.partitioning = Partitioning::UnknownPartitioning(inner.tasks.len()); |
Contributor
There was a problem hiding this comment.
We have a session variable called batch_parallelism, I think we can use this value to control the parallelism instead of using the task number directly, because the task number could be very large.
Contributor
Author
There was a problem hiding this comment.
done in new commit
Signed-off-by: Mingzhuo Yin <[email protected]>
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
EdwinaZhu
pushed a commit
to EdwinaZhu/risingwave
that referenced
this pull request
Dec 15, 2025
…bs#24065) Signed-off-by: Mingzhuo Yin <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note