-
Notifications
You must be signed in to change notification settings - Fork 715
feat: Make VALIDATE clause optional when creating webhook connection #24109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Make VALIDATE clause optional when creating webhook connection #24109
Conversation
|
|
||
| Some(expr.to_expr_proto()) | ||
| } else { | ||
| None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about suggesting to users (via notice_to_user) that a VALIDATE clause is strongly recommended for safety or production usages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message added
hzxa21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Chiro11 PTAL as well.
|
LGTM. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#21596
Made webhook validation optional by defaulting webhook metadata even when
VALIDATEis omitted and skipping signature checks when no expression is provided.Checklist
Documentation
Release note