feat(ctl): add required throttle type option for independent target/type control #24111
+28
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Co-authored-by: kwannoel <[email protected]>
…tern matching Co-authored-by: kwannoel <[email protected]>
Copilot
AI
changed the title
[WIP] Update ctl interface to add new CLI option for sink backfill
feat(ctl): add explicit throttle type option for independent target/type control
Dec 15, 2025
kwannoel
reviewed
Dec 15, 2025
Comment on lines
27
to
64
| // Infer throttle type from target for backward compatibility. | ||
| let throttle_type = match kind { | ||
| PbThrottleTarget::Source => PbThrottleType::Source, | ||
| PbThrottleTarget::Mv => PbThrottleType::Backfill, | ||
| PbThrottleTarget::Sink => PbThrottleType::Sink, | ||
| PbThrottleTarget::Table | PbThrottleTarget::Fragment | PbThrottleTarget::Unspecified => { | ||
| // Default to Backfill for unspecified/unsupported combinations; user should use SQL for table throttling | ||
| PbThrottleType::Backfill | ||
|
|
||
| // Use provided throttle type if specified, otherwise infer from target for backward compatibility | ||
| let throttle_type = if let Some(type_str) = ¶ms.throttle_type { | ||
| parse_throttle_type(type_str)? | ||
| } else { | ||
| // Infer throttle type from target for backward compatibility | ||
| match kind { | ||
| PbThrottleTarget::Source => PbThrottleType::Source, | ||
| PbThrottleTarget::Mv => PbThrottleType::Backfill, | ||
| PbThrottleTarget::Sink => PbThrottleType::Sink, | ||
| PbThrottleTarget::Table | ||
| | PbThrottleTarget::Fragment | ||
| | PbThrottleTarget::Unspecified => { | ||
| // Default to Backfill for unspecified/unsupported combinations; user should use SQL for table throttling | ||
| PbThrottleType::Backfill | ||
| } | ||
| } | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
@copilot no need to maintain backwards compatibliilty, pkease simplify.
Contributor
Author
There was a problem hiding this comment.
Simplified the code in commit 14ee937. Made --throttle-type required and removed all backward compatibility logic.
The apply_throttle function is now just 3 lines, and users must always specify the throttle type explicitly:
risectl throttle sink <id> <rate> --throttle-type backfillCo-authored-by: kwannoel <[email protected]>
Copilot
AI
changed the title
feat(ctl): add explicit throttle type option for independent target/type control
feat(ctl): add required throttle type option for independent target/type control
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Addresses review feedback from #24075 to decouple throttle target and throttle type in the ctl interface.
Previously, the ctl interface inferred throttle type from throttle target (e.g.,
sinktarget →sinktype). This prevented scenarios like applying backfill throttling to sinks.Changes:
--throttle-typeoption acceptingdml,backfill,source,sink(case-insensitive)sinksubcommand to throttle commandsUsage:
This allows independent specification of throttle target and type, enabling scenarios like sink backfill rate limiting.
Checklist
Documentation
Release note
The
risectl throttlecommand now requires the--throttle-typeflag to explicitly specify throttle type independently of the target. This enables scenarios like applying backfill throttling to sinks.Breaking change: The
--throttle-typeoption is now required for all throttle commands.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.