refactor(sink): remove sink vnode bitmap update handling - #26575
Open
wenym1 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR removes the update-vnode-bitmap path from sink execution and sink coordination. Sink actors now reject unexpected update-vnode-bitmap barriers instead of trying to apply them in place.
The main changes are:
new_vnode_bitmappropagation through sink log-store barriers and related flush/seal callbacks.execute_consume_log, including skipping no-op config updates without rewinding/restarting the log reader.This relies on the assumption that sinks will not receive in-place vnode bitmap updates. If such a barrier reaches a sink actor, the actor returns an error while handling the barrier.
Checklist
Documentation
Release note
No user-facing release note. This is an internal sink/log-store coordination refactor.
Testing
cargo fmt --all -- --check && cargo clippy --all-targets --all-features