fix(object_store): validate S3 bucket name before use (#20263) - #26585
Open
utkarshmankad wants to merge 1 commit into
Open
fix(object_store): validate S3 bucket name before use (#20263)#26585utkarshmankad wants to merge 1 commit into
utkarshmankad wants to merge 1 commit into
Task list completed / task-list-completed
succeeded
Aug 4, 2026 in 0s
3 / 3 tasks completed
All tasks have been completed
Details
Required Tasks
| Task | Status |
|---|---|
Unit tests: cargo test -p risingwave_object_store --lib validate_s3_bucket_name — 8/8 passed (valid names, underscore, bad length, uppercase, IP-address format, bad start/end char, adjacent periods, reserved prefix/suffix) |
Completed |
Integration test: cargo test -p risingwave_object_store --lib rejects_invalid_bucket — new test_build_remote_object_store_rejects_invalid_bucket_name exercises the actual build_remote_object_store() entry point with s3://rw_data and asserts it panics with "Invalid object store configuration" before any network call — 1/1 passed |
Completed |
Smoke test: ./risedev d + ./risedev psql -c "select 1;" confirms cluster start-up and query path are unaffected by the change (no regression for valid configs) |
Completed |
Loading