intermediate javascript exercise sols #29
Conversation
|
|
||
| describe("TESTS FOR mergeObjects", function() { | ||
| it("two objects", function() { | ||
| var obj1 = {name: "Foo", num: 3}; |
There was a problem hiding this comment.
careful with indentation here
testing_exercise/testing.js
Outdated
| @@ -1,0 +1,48 @@ | |||
| function replaceWith(entry, replaceChar, withChar) { | |||
| if (entry.indexOf(replaceChar) !== -1) { | |||
There was a problem hiding this comment.
nice! small thing - do you need this outer if statement?
There was a problem hiding this comment.
agreed, have taken out the outer if statement.
elie
left a comment
elie
left a comment
There was a problem hiding this comment.
Great start! Try to finish the lodash exercises and set your indentation to be 2 spaces in your editor
lodash_exercise/lodash.js
Outdated
| if (num < 0) | ||
| return num > end && num < start; | ||
| else | ||
| return num < end && num > start; |
There was a problem hiding this comment.
- indentation changed to 2 spaces on my editor.
- I tried taking off the else statement here, re-ran tests and it causes all 'inRange' tests to fail except: 'should handle negative numbers as well'
lodash_exercise/lodash.js
Outdated
|
|
||
| if(typeof a[key] === 'object') | ||
| helper(a[key]); | ||
| else |
There was a problem hiding this comment.
we shouldn't need an else return here since our function will end after these lines
There was a problem hiding this comment.
have taken out else statement here. will be checked in the next checkin.
| var eKey; | ||
| switch(shape) { | ||
| case "redT": | ||
| clear(ctx, (canvas.width), (canvas.height)); |
There was a problem hiding this comment.
If you are doing the clear in all cases, you don't need to put that code in the switch. Just do it before the switch statement. Also, you don't need the ( ) around cavas.width and canvas.height.
|
|
||
| function restartGame(ctx, width, height) { | ||
| function drawSquare(ctx, startx, starty, width, height, color) { | ||
| var square = { |
There was a problem hiding this comment.
I don't think you need to make the whole object because you don't really save it and use it later.
There was a problem hiding this comment.
the only code you really need here is:
ctx.fillStyle = color;
ctx.fillRect(startx, starty, width, height);
tigarcia
left a comment
tigarcia
left a comment
There was a problem hiding this comment.
I didn't see your hacker snooze code. Did you have a chance to submit it?
| person: { | ||
| sayHi: function(){ | ||
| return "This person's name is " + this.fullName | ||
| }.bind(obj) |
There was a problem hiding this comment.
This doesn't work because obj won't be defined yet. Here is a work around:
var obj = {
fullName: "Harry Potter",
person: {
sayHi() {
return `This person's name is ${this.fullName}`;
}
}
}
obj.person.sayHi = obj.person.sayHi.bind(obj);
| } | ||
|
|
||
| function invokeMax(fn, num) { | ||
| var count = num; |
There was a problem hiding this comment.
If you count down, you don't even need to copy the variable. Numbers are not reference types.
|
|
||
| Function.prototype.bind = function(thisArg, ...oArgs) { | ||
| var _this = this; | ||
| return function(thisArg) { |
There was a problem hiding this comment.
Putting thisArg here would break your bind. Because the local thisArg would override the thisArg from the outer fucntion. And the thisArg from the outer function is the one you want to use to bind.
|
Adding partial hack-snooze working code with login functionality working. Need to refactor code to use variable caching and implement other features. |
4 participants
No description provided.