Skip to content

fix: route Claude AskUserQuestion answers via permission control response#127

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-06-fix_route_claude_askuserquestion_answers_via_permission_control_response
Feb 7, 2026
Merged

fix: route Claude AskUserQuestion answers via permission control response#127
graphite-app[bot] merged 1 commit intomainfrom
02-06-fix_route_claude_askuserquestion_answers_via_permission_control_response

Conversation

@NathanFlurry
Copy link
Member

No description provided.

@railway-app railway-app bot temporarily deployed to sandbox-agent / sandbox-agent-pr-127 February 7, 2026 06:42 Destroyed
@railway-app
Copy link

railway-app bot commented Feb 7, 2026

🚅 Deployed to the sandbox-agent-pr-127 environment in sandbox-agent

Service Status Web Updated (UTC)
website ✅ Success (View Logs) Web Feb 7, 2026 at 6:44 am

@graphite-app
Copy link

graphite-app bot commented Feb 7, 2026

Merge activity

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app graphite-app bot force-pushed the 02-06-fix_route_claude_askuserquestion_answers_via_permission_control_response branch from e0eacdd to bdf9b7c Compare February 7, 2026 06:43
@railway-app railway-app bot temporarily deployed to sandbox-agent / sandbox-agent-pr-127 February 7, 2026 06:43 Destroyed
@graphite-app graphite-app bot merged commit bdf9b7c into main Feb 7, 2026
3 of 5 checks passed
@railway-app railway-app bot temporarily deployed to sandbox-agent / production February 7, 2026 06:45 Inactive
@railway-app railway-app bot temporarily deployed to sandbox-agent / preview February 7, 2026 06:45 Inactive
@claude
Copy link

claude bot commented Feb 7, 2026

Code review

Issue: Missing docs/conversion.mdx update

This PR changes conversion logic for Claude question events but does not update docs/conversion.mdx as required by CLAUDE.md line 39:

"Update docs/conversion.md whenever agent-native schema terms, synthetic events, identifier mappings, or conversion logic change."

Changes requiring documentation:

  1. Changed conversion flow: Question replies now route through permission control response (instead of tool_result) when a linked permission exists (router.rs:2193-2240)

  2. New synthetic events: Both PermissionResolved and QuestionResolved events are now emitted for question tools (router.rs:2254-2274)

  3. Event suppression: Permission events for question tools (AskUserQuestion, ExitPlanMode) are suppressed from frontends (router.rs:697-707)

  4. Identifier mappings: New is_question_tool_action() helper maps casing variations to question handling logic (router.rs:5207-5223)

The current docs/conversion.mdx states that question.resolved maps to tool_result (AskUserQuestion), which is no longer accurate. Please update the documentation to reflect:

  • Permission control response routing for question answers
  • Synthetic PermissionResolved events alongside QuestionResolved
  • ExitPlanMode as a question tool (not just AskUserQuestion)
  • Suppression of question-tool permissions from frontends

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments