Skip to content

fix: download binaries from R2 before npm publish #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NathanFlurry merged 1 commit into from
Jan 30, 2026
Merged

fix: download binaries from R2 before npm publish #40

NathanFlurry merged 1 commit into from
Jan 30, 2026

Conversation

@NathanFlurry
Copy link
Member

@NathanFlurry NathanFlurry commented Jan 30, 2026

The npm CLI platform packages were being published without binaries
because publishNpmCli() wasn't downloading them from R2 first.

  • Add downloadFromReleases() helper to utils.ts
  • Update publishNpmCli() to download platform binaries before publish
  • Add sdks/cli/platforms/*/bin/ to .gitignore

This was referenced Jan 30, 2026
Merged
Merged
Merged
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Jan 30, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Jan 30, 2026
Merged
@claude
Copy link

claude bot commented Jan 30, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@NathanFlurry NathanFlurry mentioned this pull request Jan 30, 2026
Merged
3 tasks
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Jan 30, 2026 •
edited
Loading

Merge activity

  • Jan 30, 7:57 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 30, 8:04 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jan 30, 8:05 AM UTC: @NathanFlurry merged this pull request with Graphite.

@NathanFlurry NathanFlurry force-pushed the fix/r2-binary-download branch from f2ab924 to f73d884 Compare January 30, 2026 08:00
@NathanFlurry NathanFlurry force-pushed the docs/quickstart-simplify branch from b13b5d7 to 9162192 Compare January 30, 2026 08:00
@NathanFlurry NathanFlurry changed the base branch from docs/quickstart-simplify to graphite-base/40 January 30, 2026 08:02
@NathanFlurry NathanFlurry changed the base branch from graphite-base/40 to main January 30, 2026 08:03
@NathanFlurry
fix: download binaries from R2 before npm publish
acc112d 
The npm CLI platform packages were being published without binaries
because publishNpmCli() wasn't downloading them from R2 first.

- Add downloadFromReleases() helper to utils.ts
- Update publishNpmCli() to download platform binaries before publish
- Add sdks/cli/platforms/*/bin/ to .gitignore
@NathanFlurry NathanFlurry force-pushed the fix/r2-binary-download branch from f73d884 to acc112d Compare January 30, 2026 08:04
@NathanFlurry NathanFlurry merged commit 394945f into main Jan 30, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanFlurry