Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mantine theme #4496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Mantine theme #4496

wants to merge 1 commit into from

Conversation

zfarhad
Copy link

@zfarhad zfarhad commented Feb 14, 2025

Reasons for making this change

Added a new theme using Mantine UI library (@mantine/core, @mantine/hooks, @mantine/dates) for react-jsonschema-form, addressing the request in issue #4289 (fixes #4289). This theme provides a modern, customizable UI component set that integrates well with RJSF's form generation capabilities.

The Mantine theme offers:

  • Modern, clean UI components
  • Built-in dark mode support
  • Responsive design
  • Accessible components
  • Customizable styling through Mantine's theming system

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@zfarhad zfarhad mentioned this pull request Feb 14, 2025
1 task
@jasny
Copy link

jasny commented Feb 14, 2025

@zfarhad No new features will be accepted to version 5. Please make a PR for version 6 instead, which currently is in alpha.

(I'm working on the primereact theme #4485 and was asked to do the same)

@heath-freenome
Copy link
Member

@zfarhad No new features will be accepted to version 5. Please make a PR for version 6 instead, which currently is in alpha.

(I'm working on the primereact theme #4485 and was asked to do the same)

@zfarhad Yes, @jasny is correct. We are only accepting critical fixes to the v5 release. Please make this change into the rjsf-v6 branch instead. Also, you will need to make changes to the ArrayFieldItemTemplate and add a GridTemplate. See the migrate v6 migration guide for more details.

@heath-freenome
Copy link
Member

Also, feel free to join the Friday meeting mentioned in the pinned issue

@zfarhad
Copy link
Author

zfarhad commented Feb 19, 2025

@zfarhad No new features will be accepted to version 5. Please make a PR for version 6 instead, which currently is in alpha.
(I'm working on the primereact theme #4485 and was asked to do the same)

@zfarhad Yes, @jasny is correct. We are only accepting critical fixes to the v5 release. Please make this change into the rjsf-v6 branch instead. Also, you will need to make changes to the ArrayFieldItemTemplate and add a GridTemplate. See the migrate v6 migration guide for more details.

Sounds great, I didn't know you were developing v6. So I will prepare the theme based on the rjsf-v6 branch and submit a new PR request on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a package for Mantine UI
3 participants