Adding a test and feat when RemoteAccountModel throws#3
Open
LucasFidelis wants to merge 2 commits intormanguinho:masterfrom
Open
Adding a test and feat when RemoteAccountModel throws#3LucasFidelis wants to merge 2 commits intormanguinho:masterfrom
LucasFidelis wants to merge 2 commits intormanguinho:masterfrom
Conversation
…untModel throws when HttpClient returns 204
…untModel throws when HttpClient returns 204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull contains a feat and test when HttpClient returns 204 to RemoteAuthentication.
When RemoteAuthentication calls RemoteAccountModel with null, this throws an Error that don't catch by try/catch block in RemoteAuthentication.
This pull request try fix it.